Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape TC message attrib for common selenium msg #154

Merged
merged 1 commit into from
Jun 3, 2014
Merged

escape TC message attrib for common selenium msg #154

merged 1 commit into from
Jun 3, 2014

Conversation

mattsonlyattack
Copy link
Contributor

turns:
[10:24:50][testing a failure] ##teamcity[testFailed name='testing a
failure' message='can't find element #cantfindme']
[10:24:50][testing a failure] Property value not found Valid property
list format is (name( )=( )'escaped_value'( )) where escape symbol
is "|"

into valid test/build failure msg:
[10:31:41][testing a failure] can't find element #cantfindme

turns:
[10:24:50][testing a failure] ##teamcity[testFailed name='testing a
failure' message='can't find element #cantfindme']
[10:24:50][testing a failure] Property value not found Valid property
list format is (name( )*=( )*'escaped_value'( )*)* where escape symbol
is "|"

into valid test/build failure msg:
[10:31:41][testing a failure] can't find element #cantfindme
@mattsonlyattack
Copy link
Contributor Author

welcome feedback on how to make this a legit PR...

@lefthandedgoat
Copy link
Owner

Check this gist out, I think I have it covered there, I just never brought it into the main code line. Would you find injecting screenshots of failures into your TC output useful?

https://gist.github.com/lefthandedgoat/9126142

Also, I will accept your pull request so you get credit for it because it is a legit fix =)

lefthandedgoat added a commit that referenced this pull request Jun 3, 2014
escape TC message attrib for common selenium msg
@lefthandedgoat lefthandedgoat merged commit 162d373 into lefthandedgoat:master Jun 3, 2014
@mattsonlyattack
Copy link
Contributor Author

Indeed your tcFriendlyMessage is much more complete than my simple hack. I haven't run into any of those other situations yet.

I'm still doing a lot of local debugging of the canopy tests as I learn how to use it, but down the road I'm sure screenshots would be useful.

Thanks!

@skalinets
Copy link
Contributor

could you roll this change to nuget?

lefthandedgoat added a commit that referenced this pull request Jul 2, 2014
@lefthandedgoat
Copy link
Owner

Done. Sorry about the delay!

https://www.nuget.org/packages/canopy/0.9.12

@skalinets
Copy link
Contributor

Fantastic! Thank you very much for the quick turnaround :)

Regards,
Serhiy Kalinets

2014-07-02 19:06 GMT+03:00 lefthandedgoat [email protected]:

Done. Sorry about the delay!

https://www.nuget.org/packages/canopy/0.9.12


Reply to this email directly or view it on GitHub
#154 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants